> On May 10, 2017, 3:13 p.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > > Lines 87 (patched) > > <https://reviews.apache.org/r/59015/diff/2/?file=1713945#file1713945line87> > > > > s/Secret::Value/JSON::Object/ > > > > This file doesn't need to know about secrets AFAICT?
Chatted offline. We will move the getAuthHeader to fetch() to avoid new parameter. Will follow up with the refactor. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59015/#review174580 ----------------------------------------------------------- On May 10, 2017, 5:47 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59015/ > ----------------------------------------------------------- > > (Updated May 10, 2017, 5:47 a.m.) > > > Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7088 > https://issues.apache.org/jira/browse/MESOS-7088 > > > Repository: mesos > > > Description > ------- > > Implemented passing docker config depended methods. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b > > > Diff: https://reviews.apache.org/r/59015/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
