> On May 10, 2017, 6:12 p.m., Chun-Hung Hsiao wrote: > > src/uri/fetchers/docker.cpp > > Lines 328 (patched) > > <https://reviews.apache.org/r/59018/diff/2/?file=1713959#file1713959line328> > > > > Why are we using `secretValue` instead of `config` as in other places? > > Also, it seems to me that `uri` and `secretValue` are coupled, so how about > > putting them side by side in the parameter list? Same for the following > > code.
OK I got why we're using `secretValue`. Please refer to my comment in https://reviews.apache.org/r/59141/. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/#review174511 ----------------------------------------------------------- On May 10, 2017, 12:48 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59018/ > ----------------------------------------------------------- > > (Updated May 10, 2017, 12:48 p.m.) > > > Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7088 > https://issues.apache.org/jira/browse/MESOS-7088 > > > Repository: mesos > > > Description > ------- > > Supported Image::Secret in docker URI fetcher plugin. > > > Diffs > ----- > > src/uri/fetchers/docker.cpp 44169bf5f22f0ffd9fad7bb3b8f7d2a4989c6415 > > > Diff: https://reviews.apache.org/r/59018/diff/2/ > > > Testing > ------- > > make check > > Manually tested using mesos-execute with task group. Verified that pulling > separate private image from different registries using different image > secrets works correctly. > > > Thanks, > > Gilbert Song > >
