----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/#review174584 -----------------------------------------------------------
src/uri/fetchers/docker.cpp Line 492 (original), 502 (patched) <https://reviews.apache.org/r/59018/#comment247751> unrelated to this review but this should probably be plural "getAuthHeaders" given this is returning `http::Headers`. maybe update in a different review? src/uri/fetchers/docker.cpp Line 492 (original), 502 (patched) <https://reviews.apache.org/r/59018/#comment247752> unrelated to this review but this should probably be plural "getAuthHeaders" given this is returning `http::Headers`. maybe update in a different review? src/uri/fetchers/docker.cpp Line 505 (original), 516 (patched) <https://reviews.apache.org/r/59018/#comment247789> As discussed offline passing headers and secrets here is very confusing. We should add some comments on the semantics of http headers and secret value, which is used when, auth assumptions regarding manifest server and blob servers etc, for posterity. - Vinod Kone On May 10, 2017, 12:48 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59018/ > ----------------------------------------------------------- > > (Updated May 10, 2017, 12:48 p.m.) > > > Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7088 > https://issues.apache.org/jira/browse/MESOS-7088 > > > Repository: mesos > > > Description > ------- > > Supported Image::Secret in docker URI fetcher plugin. > > > Diffs > ----- > > src/uri/fetchers/docker.cpp 44169bf5f22f0ffd9fad7bb3b8f7d2a4989c6415 > > > Diff: https://reviews.apache.org/r/59018/diff/2/ > > > Testing > ------- > > make check > > Manually tested using mesos-execute with task group. Verified that pulling > separate private image from different registries using different image > secrets works correctly. > > > Thanks, > > Gilbert Song > >
