----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59216/#review174852 -----------------------------------------------------------
Fix it, then Ship it! Any reason not to be adding the deprecated tag here? include/mesos/master/master.proto Line 378 (original), 378 (patched) <https://reviews.apache.org/r/59216/#comment248069> and is deprecated? Ditto for tasks include/mesos/master/master.proto Lines 380-381 (original), 380-381 (patched) <https://reviews.apache.org/r/59216/#comment248070> Just to clarify the intent of this comment, our deprecation cycle technically means that we can't remove this until 2.0, right? include/mesos/master/master.proto Line 382 (original), 382 (patched) <https://reviews.apache.org/r/59216/#comment248068> Why not add the deprecation tag here and for tasks? ``` repeated Task orphan_executors = 4 [deprecated = true]; ``` - Benjamin Mahler On May 11, 2017, 11:32 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59216/ > ----------------------------------------------------------- > > (Updated May 11, 2017, 11:32 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-6977 > https://issues.apache.org/jira/browse/MESOS-6977 > > > Repository: mesos > > > Description > ------- > > Orphan tasks/executors are still possible in Mesos 1.2.0; they are not > possible with Mesos 1.2.1 or Mesos >= 1.3.0. > > > Diffs > ----- > > include/mesos/master/master.proto 841e207a40228dcad7210aae69cfdd2059183367 > > > Diff: https://reviews.apache.org/r/59216/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
