> On May 12, 2017, 9:37 p.m., Benjamin Mahler wrote: > > include/mesos/master/master.proto > > Line 382 (original), 382 (patched) > > <https://reviews.apache.org/r/59216/diff/1/?file=1716305#file1716305line382> > > > > Why not add the deprecation tag here and for tasks? > > > > ``` > > repeated Task orphan_executors = 4 [deprecated = true]; > > ```
I did this in a separate review: https://reviews.apache.org/r/59301/ - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59216/#review174852 ----------------------------------------------------------- On May 15, 2017, 11:16 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59216/ > ----------------------------------------------------------- > > (Updated May 15, 2017, 11:16 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-6977 > https://issues.apache.org/jira/browse/MESOS-6977 > > > Repository: mesos > > > Description > ------- > > Orphan tasks/executors are still possible in Mesos 1.2.0; they are not > possible with Mesos 1.2.1 or Mesos >= 1.3.0. > > > Diffs > ----- > > include/mesos/master/master.proto 841e207a40228dcad7210aae69cfdd2059183367 > > > Diff: https://reviews.apache.org/r/59216/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
