----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/#review174912 -----------------------------------------------------------
include/mesos/secret/resolver.hpp Lines 26-35 (patched) <https://reviews.apache.org/r/58759/#comment248182> Did we try to get rid of the c style comments: ``` /** * */ ``` and insist on c++ ctyle comments: ``` // // // ``` ditto to the others. - Gilbert Song On May 12, 2017, 10:52 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58759/ > ----------------------------------------------------------- > > (Updated May 12, 2017, 10:52 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-7418 > https://issues.apache.org/jira/browse/MESOS-7418 > > > Repository: mesos > > > Description > ------- > > Introduced SecretResolver module interface. > > > Diffs > ----- > > include/mesos/module.hpp c28d01df54906b2b8ebfe7ac9e719a0d1be45614 > include/mesos/module/secret_resolver.hpp PRE-CREATION > include/mesos/secret/resolver.hpp PRE-CREATION > src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a > src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 > > > Diff: https://reviews.apache.org/r/58759/diff/8/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
