----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59194/#review174924 -----------------------------------------------------------
Fix it, then Ship it! src/common/resources.cpp Lines 1417-1419 (patched) <https://reviews.apache.org/r/59194/#comment248200> The explanation reads like there's a particular rule that stipulates the requirement of "a single copy" but ultimately it just comes down to "if the volume is removed", which is self-evident in the code. The error message also reminds the reader about the "additional shared copy". I feel it's clear enough without the sentence. src/tests/resources_tests.cpp Lines 2577 (patched) <https://reviews.apache.org/r/59194/#comment248202> `__total`? - Jiang Yan Xu On May 12, 2017, 9:50 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59194/ > ----------------------------------------------------------- > > (Updated May 12, 2017, 9:50 p.m.) > > > Review request for mesos, James Peach and Jiang Yan Xu. > > > Bugs: MESOS-7403 > https://issues.apache.org/jira/browse/MESOS-7403 > > > Repository: mesos > > > Description > ------- > > Ensure that applying `DESTROY` operation removes this volume. This is > needed to handle `DESTROY` of shared volumes to ensure that the > resultant `Resources` object has this `Resource` removed (i.e. we > allow this operation to succeed if the original `Resources` object > had a single copy of the shared resource). > > > Diffs > ----- > > src/common/resources.cpp f6f02eb0a7ca05ab8fd9a670f32428862009b7d5 > src/tests/resources_tests.cpp 4cf320d802a749f1419ac5b9f63b6c73b0c974be > src/v1/resources.cpp cad069defb34d5ccc20a0e083eb88cb80f70e415 > > > Diff: https://reviews.apache.org/r/59194/diff/2/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
