----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59194/#review175033 -----------------------------------------------------------
Ship it! Ship It! - Jiang Yan Xu On May 15, 2017, 11:01 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59194/ > ----------------------------------------------------------- > > (Updated May 15, 2017, 11:01 a.m.) > > > Review request for mesos, James Peach and Jiang Yan Xu. > > > Bugs: MESOS-7403 > https://issues.apache.org/jira/browse/MESOS-7403 > > > Repository: mesos > > > Description > ------- > > Ensure that applying `DESTROY` operation removes this volume. This is > needed to handle `DESTROY` of shared volumes to ensure that the > resultant `Resources` object has this `Resource` removed (i.e. we > allow this operation to succeed if the original `Resources` object > only had a single copy of the shared resource). > > > Diffs > ----- > > src/common/resources.cpp f6f02eb0a7ca05ab8fd9a670f32428862009b7d5 > src/tests/resources_tests.cpp 4cf320d802a749f1419ac5b9f63b6c73b0c974be > src/v1/resources.cpp cad069defb34d5ccc20a0e083eb88cb80f70e415 > > > Diff: https://reviews.apache.org/r/59194/diff/3/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
