----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59293/ -----------------------------------------------------------
Review request for mesos and Joseph Wu. Repository: mesos Description ------- Write using 'wb' instead of 'w' for binary mode. This writes the downloaded patch file exactly as it came, instead of treating as text and changing line endings. This resolves a bug where `git apply` doesn't always work with CRLF endings in patch files. Diffs ----- support/apply-reviews.py b495675de80fd995f208f1b9ca8c88a717cf2850 Diff: https://reviews.apache.org/r/59293/diff/1/ Testing ------- Applied patch 59177 successfully after failing to apply it without change due to: ``` 59177.patch:9: trailing whitespace. 59177.patch:18: trailing whitespace. def autocomplete(cmds, plugins, config, argv): 59177.patch:26: trailing whitespace. current_word = argv[0] 59177.patch:27: trailing whitespace. argv = argv[1:] 59177.patch:36: trailing whitespace. return plugin_class(settings, config).__autocomplete_base__( error: git apply: bad git-diff - expected /dev/null on line 167 ``` Thanks, Andrew Schwartzmeyer
