----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58513/#review175166 -----------------------------------------------------------
Fix it, then Ship it! Please rebase. 3rdparty/CMakeLists.txt Line 349 (original), 348 (patched) <https://reviews.apache.org/r/58513/#comment248557> This line can be removed as well. - Chun-Hung Hsiao On April 18, 2017, 10:48 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58513/ > ----------------------------------------------------------- > > (Updated April 18, 2017, 10:48 p.m.) > > > Review request for mesos, Anand Mazumdar and Joseph Wu. > > > Bugs: MESOS-7228 > https://issues.apache.org/jira/browse/MESOS-7228 > > > Repository: mesos > > > Description > ------- > > The patch should already be included in protobuf 3.0.0, so > this is not necessary anymore. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt bb61ef0514fb164f35b34bb6be1bbebb4d1a1861 > 3rdparty/Makefile.am 61d832b2d83cdeaf95341c062e8493ab72d0724e > 3rdparty/protobuf-2.6.1.patch bfd3bb2c600383ef05bdb4ea9df0188b4a560315 > > > Diff: https://reviews.apache.org/r/58513/diff/2/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
