----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58358/#review175168 -----------------------------------------------------------
I personally don't like using an RC version. We should update protobuf to an official release, say 3.3.1? - Chun-Hung Hsiao On April 25, 2017, 10:51 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58358/ > ----------------------------------------------------------- > > (Updated April 25, 2017, 10:51 p.m.) > > > Review request for mesos, Anand Mazumdar and Joseph Wu. > > > Bugs: MESOS-7228 > https://issues.apache.org/jira/browse/MESOS-7228 > > > Repository: mesos > > > Description > ------- > > The content of `3rdparty/protobuf-3.2.0.tar.gz` is generated by: > - On a Mac OS, download and untar protobuf v3.2.0 source at > https://github.com/google/protobuf/archive/v3.2.0rc2.tar.gz; > - Run `./autogen.sh`; > - Recompress and tar by `tar -czvf`. > > Note that reviewboard seems to have problem for uploading/dowloading binary > patches, so this particular commit is also available at > https://github.com/apache/mesos/pull/208 > > > Diffs > ----- > > 3rdparty/protobuf-2.6.1.tar.gz e1c2d541c1eb806e837ff5d1e9d3fdb678b40e06 > 3rdparty/protobuf-3.2.0.tar.gz PRE-CREATION > > > Diff: https://reviews.apache.org/r/58358/diff/4/ > > > Testing > ------- > > 1. make check; > 2. used the modified `test-upgrade.py` in r/58357 to test upgrade/downgrade > between this chain and Mesos 1.2; > 3. build this branch in Apache Aurora's vagrant based box, and verifies that > Aurora scheduler (using java) and executor (using python) still works with > `libmesos.so` built from this branch. > > > Thanks, > > Zhitao Li > >
