> On April 17, 2017, 5:49 p.m., Jie Yu wrote: > > src/tests/resources_tests.cpp > > Lines 2255 (patched) > > <https://reviews.apache.org/r/58048/diff/3/?file=1685272#file1685272line2255> > > > > instead of relying on 'count', let's use `size()` instead.
I think here the intention is to count how many `disks` are in `(r1 + r2)`, so `count()` should be the right method to call. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/#review172076 ----------------------------------------------------------- On April 5, 2017, 9:56 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58048/ > ----------------------------------------------------------- > > (Updated April 5, 2017, 9:56 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-7312 > https://issues.apache.org/jira/browse/MESOS-7312 > > > Repository: mesos > > > Description > ------- > > Ids will allow to create distinguishable resources, e.g., of RAW or > BLOCK type. > > > Diffs > ----- > > include/mesos/mesos.proto dd90465cc3da283c078d4e907cc6a4a0e50309ac > include/mesos/v1/mesos.proto 228623155c7f68c0f24d173aacbc6eb734f1382f > src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a > src/tests/mesos.hpp fe897c184829910addec95ace174546092a9e2b2 > src/tests/resources_tests.cpp 343cab2af225a05e32c5a8bd4a5d9ddfbf76536d > src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11 > > > Diff: https://reviews.apache.org/r/58048/diff/3/ > > > Testing > ------- > > make check (OS X, Fedora25) > > > Thanks, > > Benjamin Bannier > >
