> On April 25, 2017, 5:31 p.m., James Peach wrote: > > The code looks fine. As per the other revires this needs documentation. > > > > Please update the metric names in the commit. The metrics are > > `allocator/mesos/frameworks/<role>` not > > `allocator/mesos/frameworks/role/<role>`.
Added documentation, and fixed the commit message. Thanks for catching that. - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53842/#review172952 ----------------------------------------------------------- On May 23, 2017, 4:30 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53842/ > ----------------------------------------------------------- > > (Updated May 23, 2017, 4:30 p.m.) > > > Review request for mesos, James Peach and Jiang Yan Xu. > > > Bugs: MESOS-6579 > https://issues.apache.org/jira/browse/MESOS-6579 > > > Repository: mesos > > > Description > ------- > > Added the following 2 metrics which is maintained on a role level > (as long as there is at least one framework of that role): > a) allocator/mesos/frameworks/role/<role>/sort_runs: Number of framework > level sorts (based on role) in DRF Sorter. > b) allocator/mesos/frameworks/role/<role>/sort_run: Latency in framework > level sorts (based on role) in DRF Sorter. > > > Diffs > ----- > > docs/monitoring.md a027f4905a0e6e41ff4e1348d34fd7aa5f1cbe61 > src/master/allocator/mesos/hierarchical.hpp > 123f97cf495bff0f822838e09df0d88818f04da6 > src/master/allocator/mesos/hierarchical.cpp > b75ed9a20a9a42f958cebbacd91e5e15b0d21394 > src/tests/hierarchical_allocator_tests.cpp > 6dee2296d5a14185dbf7eee17968b20148839bfd > > > Diff: https://reviews.apache.org/r/53842/diff/7/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
