----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59634/#review176289 -----------------------------------------------------------
Patch looks great! Reviews applied: [59634] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 29, 2017, 11:32 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59634/ > ----------------------------------------------------------- > > (Updated May 29, 2017, 11:32 p.m.) > > > Review request for mesos and Armand Grillet. > > > Repository: mesos > > > Description > ------- > > Previously, we were importing settings directly from the `bin` > directory, which is obviously not portable. Instead, we need to be > passing the settings into the constructor for the config so that it > can access it from there. > > > Diffs > ----- > > src/cli_new/lib/cli/config.py 353785b8bdc13b745d2dc9469201c16a8816ebc6 > > > Diff: https://reviews.apache.org/r/59634/diff/1/ > > > Testing > ------- > > Tested manually, PEP8 and Pylint used to make sure that the code style is > correct. > > > Thanks, > > Kevin Klues > >
