-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59634/#review176290
-----------------------------------------------------------
When using the command `mesos` after applying your patch on top of master, I
got this error:
```
Traceback (most recent call last):
File "/Users/Armand/Code/apache-mesos/src/cli_new/bin/main.py", line 151, in
<module>
main(sys.argv[1:])
File "/Users/Armand/Code/apache-mesos/src/cli_new/bin/main.py", line 87, in
main
config = cli.config.Config()
TypeError: __init__() takes exactly 2 arguments (1 given)
```
Replacing the line 87 of bin/main.py by `config = cli.config.Config(settings)`
solved the issue.
- Armand Grillet
On May 29, 2017, 11:32 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59634/
> -----------------------------------------------------------
>
> (Updated May 29, 2017, 11:32 p.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, we were importing settings directly from the `bin`
> directory, which is obviously not portable. Instead, we need to be
> passing the settings into the constructor for the config so that it
> can access it from there.
>
>
> Diffs
> -----
>
> src/cli_new/lib/cli/config.py 353785b8bdc13b745d2dc9469201c16a8816ebc6
>
>
> Diff: https://reviews.apache.org/r/59634/diff/1/
>
>
> Testing
> -------
>
> Tested manually, PEP8 and Pylint used to make sure that the code style is
> correct.
>
>
> Thanks,
>
> Kevin Klues
>
>
