----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59525/#review176735 -----------------------------------------------------------
src/master/http.cpp Lines 402-403 (patched) <https://reviews.apache.org/r/59525/#comment250182> It's not clear to me why we would want to show the unapproved resources in a special field? src/master/http.cpp Line 2365 (original), 2380 (patched) <https://reviews.apache.org/r/59525/#comment250185> Nit: I think this indent is two spaces too large. I know it's within the parentheses of a function call, but since it's also within the lambda's `{}`, I think a two space indent is appropriate here? src/master/http.cpp Lines 2382 (patched) <https://reviews.apache.org/r/59525/#comment250186> Ditto regarding indent. src/master/http.cpp Lines 2385 (patched) <https://reviews.apache.org/r/59525/#comment250187> Nit: I think the ident here can be aligned with the `writer->field( ... ) {` line, since this curly brace is closing out the lambda. src/master/http.cpp Lines 2391-2395 (original), 2417-2421 (patched) <https://reviews.apache.org/r/59525/#comment250188> Ditto regarding indentation. src/master/http.cpp Lines 2485 (patched) <https://reviews.apache.org/r/59525/#comment250189> s/Master *master/Master* master/ - Greg Mann On June 1, 2017, 2:58 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59525/ > ----------------------------------------------------------- > > (Updated June 1, 2017, 2:58 p.m.) > > > Review request for mesos, Adam B, Greg Mann, and Till Toenshoff. > > > Bugs: MESOS-7416 > https://issues.apache.org/jira/browse/MESOS-7416 > > > Repository: mesos > > > Description > ------- > > Adds support of the `VIEW_ROLE` ACL to the results generated by > the `/slaves` as well as the `GET_AGENTS` API v1 call. This means > that calls to this endpoint (API call) will hide roles that the > user making the request is not authorized to see. > > > Diffs > ----- > > src/master/http.cpp eb80830fa003ad8f58243d3dc4cec9e03285e96f > src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732 > > > Diff: https://reviews.apache.org/r/59525/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
