> On June 2, 2017, 9 a.m., Greg Mann wrote: > > src/master/http.cpp > > Lines 402-403 (patched) > > <https://reviews.apache.org/r/59525/diff/2/?file=1735837#file1735837line402> > > > > It's not clear to me why we would want to show the unapproved resources > > in a special field?
Not sure if it is necesary write it in the TODO, because it may be too verbose, but the reason is that if you have X resources, and you have Y unreserved resources, and Z_i reserved resources, you would expect that Y+SUM(i, Z_i) = X, but if we hide the unapproved ones without checking where they are a user may be wondering if perhaps it is a bug. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59525/#review176735 ----------------------------------------------------------- On June 1, 2017, 4:58 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59525/ > ----------------------------------------------------------- > > (Updated June 1, 2017, 4:58 p.m.) > > > Review request for mesos, Adam B, Greg Mann, and Till Toenshoff. > > > Bugs: MESOS-7416 > https://issues.apache.org/jira/browse/MESOS-7416 > > > Repository: mesos > > > Description > ------- > > Adds support of the `VIEW_ROLE` ACL to the results generated by > the `/slaves` as well as the `GET_AGENTS` API v1 call. This means > that calls to this endpoint (API call) will hide roles that the > user making the request is not authorized to see. > > > Diffs > ----- > > src/master/http.cpp eb80830fa003ad8f58243d3dc4cec9e03285e96f > src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732 > > > Diff: https://reviews.apache.org/r/59525/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
