----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59763/#review176839 -----------------------------------------------------------
Bad patch! Reviews applied: [59763, 59762, 59761, 59760, 59759] Failed command: python support/apply-reviews.py -n -r 59760 Error: error: patch failed: include/mesos/mesos.proto:343 error: include/mesos/mesos.proto: patch does not apply error: patch failed: include/mesos/v1/mesos.proto:343 error: include/mesos/v1/mesos.proto: patch does not apply Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/console - Mesos Reviewbot Windows On June 2, 2017, 8:11 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59763/ > ----------------------------------------------------------- > > (Updated June 2, 2017, 8:11 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-7611 > https://issues.apache.org/jira/browse/MESOS-7611 > > > Repository: mesos > > > Description > ------- > > That is, if a standby master is configured to use region X but it learns > that the current master has region Y, the standby master will abort with > an error message. This enforces the requirement that all masters in a > single Mesos cluster are configured to use the same region (they can be > configured to use different zones in that region, however). > > To allow graceful upgrades, we only abort the standby master if both the > standby master and the leading master have a configured domain; if > either master has the unset (default) domain, the standby master does > not abort. > > NOTE: It would be nice to have unit tests to validate this behavior, but > the current unit test infrastructure does not support starting multiple > masters (MESOS-2976). > > > Diffs > ----- > > include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7 > include/mesos/v1/mesos.hpp c2e6ec5c4fa06d0179d6aaf3371ace4b6e6dbdaf > src/master/master.cpp c66907bd55cb2eb549ec89f048d41376df556eb9 > > > Diff: https://reviews.apache.org/r/59763/diff/1/ > > > Testing > ------- > > `make check` > > Manual testing. > > > Thanks, > > Neil Conway > >
