----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59766/#review176942 -----------------------------------------------------------
Have you considered implementing this change outside of the allocator? It seems unfortunate that we keep pushing more problem-specific workarounds into the allocator which both complicates the `HierarchicalAllocator` and makes implementing custom allocators harder. It seems to me that a filtering policy like this one (and e.g., also the work done here for GPUs), could be done just as well e.g., with `Filters`, i.e., for not region-aware frameworks a master could automatically inject `Filters` for all affected agents (this would require some adjustments to the effects of `revive` calls). Alternatively, one could imagine augmenting the allocator interface to allow injecting filtering policies (e.g., by passing a collection of callbacks). - Benjamin Bannier On June 5, 2017, 8:30 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59766/ > ----------------------------------------------------------- > > (Updated June 5, 2017, 8:30 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-7614 > https://issues.apache.org/jira/browse/MESOS-7614 > > > Repository: mesos > > > Description > ------- > > Changed allocator to offer remote resources to region-aware frameworks. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > b31fbcfc18cbbe1e6b5fb5ccbc234f790326a5b4 > src/master/allocator/mesos/allocator.hpp > b2dcb566c49a1bbb1d955ca46e1c8eef91e62733 > src/master/allocator/mesos/hierarchical.hpp > 5e7c3068061012c51d4b9220dedf476408016a12 > src/master/allocator/mesos/hierarchical.cpp > 8ebdbc6a2b98feab7ce4d7f07b15d8fb92992270 > src/master/master.cpp c66907bd55cb2eb549ec89f048d41376df556eb9 > src/tests/allocator.hpp 0b9fdeaccc65bb6988103ac156e0584cf5df17fe > src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54 > src/tests/master_allocator_tests.cpp > 0082045ccaebe015725c5e178aa89dac32b1c50c > src/tests/master_quota_tests.cpp 6ca45706f47b7d75db519f98af64e6a52091eb84 > src/tests/master_tests.cpp 490d7ed4b275ebf5ff6956f7d40dbea3ce3b63e2 > src/tests/persistent_volume_endpoints_tests.cpp > 9b820b8f4e0d0e2c62b5c9b420b790cdfb59dd0c > src/tests/reservation_endpoints_tests.cpp > 505c5421e95378177a7a09f462e5625ffa75cd37 > src/tests/reservation_tests.cpp 34628eed671aee7ed69497d282c8043d65620c14 > src/tests/resource_offers_tests.cpp > 7ad037e5ec1d63cc8c2b8b0ad092e3f5f6f402c8 > src/tests/slave_recovery_tests.cpp 86cf971aa8aea012a74740a4dcbaf5ed2ad9c866 > > > Diff: https://reviews.apache.org/r/59766/diff/2/ > > > Testing > ------- > > `make check`. > > > Thanks, > > Neil Conway > >
