----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59766/#review180144 -----------------------------------------------------------
Fix it, then Ship it! src/master/allocator/mesos/hierarchical.hpp Lines 527-528 (original), 533 (patched) <https://reviews.apache.org/r/59766/#comment255162> bad rebase? src/master/allocator/mesos/hierarchical.hpp Lines 536 (patched) <https://reviews.apache.org/r/59766/#comment255163> s/slave/agent/ src/master/allocator/mesos/hierarchical.cpp Lines 2389 (patched) <https://reviews.apache.org/r/59766/#comment255164> s/slave/agent/ src/tests/master_tests.cpp Lines 7406 (patched) <https://reviews.apache.org/r/59766/#comment255166> can you check that offer contains the domain? - Vinod Kone On July 10, 2017, 5:26 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59766/ > ----------------------------------------------------------- > > (Updated July 10, 2017, 5:26 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-7614 > https://issues.apache.org/jira/browse/MESOS-7614 > > > Repository: mesos > > > Description > ------- > > Changed allocator to offer remote resources to region-aware frameworks. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > 9d116c68fe7225178bba85414cb88d97fa0dbed5 > src/master/allocator/mesos/allocator.hpp > 725ec7c3348b3f5c66bb6530983ee212480c5974 > src/master/allocator/mesos/hierarchical.hpp > 81d1b964800ef69e25bc874dbadcdfcfd47392b2 > src/master/allocator/mesos/hierarchical.cpp > fad9330dc371728e72eb2af808e993c4c97543af > src/master/master.cpp 7668749cc4658627ed3bdd6cdcf7e837daece8d6 > src/tests/allocator.hpp a990788d5218bbcac499613783750ade022811a7 > src/tests/api_tests.cpp cdaa72462eac1687185115771265539d8c2b09a9 > src/tests/master_allocator_tests.cpp > f83ca66e64fe6d2d10d104ff24f31afd84c50a3a > src/tests/master_quota_tests.cpp bbdbfbe9d9960cdc9fa7b2d56e9da9122d25db6a > src/tests/master_tests.cpp c778c6c56d47c4033189912cebee6024be79106f > src/tests/reservation_tests.cpp 3b4884be21a0b4f15bcbc1a58fa4a4ad7858a7fb > src/tests/resource_offers_tests.cpp > 427a6520034a537caf748a126001d131e196fedd > src/tests/slave_recovery_tests.cpp f6eafcbe3d89c7a69c03db0fd7bc10ae73d06584 > > > Diff: https://reviews.apache.org/r/59766/diff/5/ > > > Testing > ------- > > `make check`. > > > Thanks, > > Neil Conway > >
