----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59898/#review177318 -----------------------------------------------------------
Fix it, then Ship it! LGTM, modulo the nit below. src/slave/containerizer/docker.cpp Lines 424-425 (patched) <https://reviews.apache.org/r/59898/#comment250842> Nit: Two space indent here. - Joseph Wu On June 7, 2017, 4:11 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59898/ > ----------------------------------------------------------- > > (Updated June 7, 2017, 4:11 p.m.) > > > Review request for mesos, Adam B, Kapil Arya, and Joseph Wu. > > > Bugs: MESOS-7640 > https://issues.apache.org/jira/browse/MESOS-7640 > > > Repository: mesos > > > Description > ------- > > Without this patch, the Docker containerizer would not inherit the > ownership of stdout/stderr from the FrameworkInfo user. This issue > got introduced recently in the refactorings of the Docker > containerizer. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 9f84109d7de22a39ace6e44e0c7d8d501bcb24de > > > Diff: https://reviews.apache.org/r/59898/diff/1/ > > > Testing > ------- > > make check && functional test > > > Thanks, > > Till Toenshoff > >
