> On June 8, 2017, 4:12 p.m., Joseph Wu wrote:
> > src/slave/containerizer/docker.cpp
> > Lines 424-425 (patched)
> > <https://reviews.apache.org/r/59898/diff/1/?file=1744125#file1744125line424>
> >
> > Nit: Two space indent here.
mesos-clang-format does it even nicer... shall we go with that?
```
return fetcher->fetch(
containerId,
container->command,
container->containerWorkDir,
container->containerConfig.has_user() ? container->containerConfig.user()
: Option<string>::none());
```
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59898/#review177318
-----------------------------------------------------------
On June 7, 2017, 11:11 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59898/
> -----------------------------------------------------------
>
> (Updated June 7, 2017, 11:11 p.m.)
>
>
> Review request for mesos, Adam B, Kapil Arya, and Joseph Wu.
>
>
> Bugs: MESOS-7640
> https://issues.apache.org/jira/browse/MESOS-7640
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Without this patch, the Docker containerizer would not inherit the
> ownership of stdout/stderr from the FrameworkInfo user. This issue
> got introduced recently in the refactorings of the Docker
> containerizer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9f84109d7de22a39ace6e44e0c7d8d501bcb24de
>
>
> Diff: https://reviews.apache.org/r/59898/diff/2/
>
>
> Testing
> -------
>
> make check && functional test
>
>
> Thanks,
>
> Till Toenshoff
>
>
