----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59185/#review177568 -----------------------------------------------------------
Fix it, then Ship it! Nice tests! src/linux/capabilities.cpp Lines 256-258 (patched) <https://reviews.apache.org/r/59185/#comment251258> I would move the implementation of `_ambientCapabilitiesSupported` to this constructor. src/linux/capabilities.cpp Lines 254-256 (original), 322-325 (patched) <https://reviews.apache.org/r/59185/#comment251257> I would inline the implementation here. We usually do not factor out a helper if it is only used in one place. If you do want to facator out a helper, inline lambda is better than a static method. src/tests/containerizer/capabilities_tests.cpp Lines 201-202 (patched) <https://reviews.apache.org/r/59185/#comment251259> Style nits: This should be ``` wanted.set( capabilities::INHERITABLE, {capabilities::SETPCAP, capabilities::CHOWN}); ``` src/tests/containerizer/capabilities_tests.cpp Lines 203-204 (patched) <https://reviews.apache.org/r/59185/#comment251260> Ditto. src/tests/containerizer/capabilities_tests.cpp Lines 207-208 (patched) <https://reviews.apache.org/r/59185/#comment251261> Ditto. - Jie Yu On June 5, 2017, 4:50 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59185/ > ----------------------------------------------------------- > > (Updated June 5, 2017, 4:50 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-7477 > https://issues.apache.org/jira/browse/MESOS-7477 > > > Repository: mesos > > > Description > ------- > > Add support for the ambient capability so that we can make > effective capabilities survive across execve(2). > > > Diffs > ----- > > src/linux/capabilities.hpp 5fa3799948f8ac4bcaeaa89f91d7d090e426c5a6 > src/linux/capabilities.cpp 7aa8c352def644468e8c9041a2fe4319f313b09b > src/tests/containerizer/capabilities_tests.cpp > 15a85cab87c28402eeb2bfbc751c8c77bf4c14f5 > > > Diff: https://reviews.apache.org/r/59185/diff/4/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > James Peach > >
