> On June 11, 2017, 5:20 p.m., Jie Yu wrote: > > src/linux/capabilities.cpp > > Lines 256-258 (patched) > > <https://reviews.apache.org/r/59185/diff/4/?file=1747638#file1747638line256> > > > > I would move the implementation of `_ambientCapabilitiesSupported` to > > this constructor.
It is done this way so that `Capabilities::ambientCapabilitiesSupported` can be a const data member. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59185/#review177568 ----------------------------------------------------------- On June 5, 2017, 4:50 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59185/ > ----------------------------------------------------------- > > (Updated June 5, 2017, 4:50 p.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-7477 > https://issues.apache.org/jira/browse/MESOS-7477 > > > Repository: mesos > > > Description > ------- > > Add support for the ambient capability so that we can make > effective capabilities survive across execve(2). > > > Diffs > ----- > > src/linux/capabilities.hpp 5fa3799948f8ac4bcaeaa89f91d7d090e426c5a6 > src/linux/capabilities.cpp 7aa8c352def644468e8c9041a2fe4319f313b09b > src/tests/containerizer/capabilities_tests.cpp > 15a85cab87c28402eeb2bfbc751c8c77bf4c14f5 > > > Diff: https://reviews.apache.org/r/59185/diff/4/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > James Peach > >
