----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60003/#review177625 -----------------------------------------------------------
Patch looks great! Reviews applied: [60002, 60003] Passed command: support\windows-build.bat - Mesos Reviewbot Windows On June 12, 2017, 2:53 p.m., Dmitry Zhuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60003/ > ----------------------------------------------------------- > > (Updated June 12, 2017, 2:53 p.m.) > > > Review request for mesos, haosdent huang and Michael Park. > > > Repository: mesos > > > Description > ------- > > Reduced copying in defer, dispatch and Future. > > This reduces number of copies made for each parameter in a code like this: > future.then(defer(pid, &SomeProcess::someMethod, param1, param2)); > > For the objects that do not support move semantics (e.g. protobuf messages), > number of copies is reduced from 8-10 to 6. If move semantics is supported, > then number of copies is reduced from 6-7 to 1 if parameter is passed with > std::move, or 2 otherwise. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/defer.hpp > 7f3369e723cb244e97930621cbba89cf7873567d > 3rdparty/libprocess/include/process/deferred.hpp > e446621be11ac51f5f91c417cc8975e363c2f715 > 3rdparty/libprocess/include/process/dispatch.hpp > 3a0793888dc0df5e3ec31b06f47cd920c71e0db9 > 3rdparty/libprocess/include/process/future.hpp > cce950509f58022e79bb51a6e72ea1a005b9cb50 > 3rdparty/libprocess/include/process/http.hpp > f637999174d92a98208b5fc49a65f9929efb11a0 > > > Diff: https://reviews.apache.org/r/60003/diff/1/ > > > Testing > ------- > > make check > > Number of copies was checked by using defer to subscribe process for Future > callbacks, and passing parameters that count number of copies made. > > > Thanks, > > Dmitry Zhuk > >
