----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59099/#review177606 -----------------------------------------------------------
Fix it, then Ship it! src/master/http.cpp Lines 4113 (patched) <https://reviews.apache.org/r/59099/#comment251322> This should be safer by adding a `defer` as well given that you are capturing `this`, no? src/master/http.cpp Lines 4096-4098 (original), 4137-4141 (patched) <https://reviews.apache.org/r/59099/#comment251309> This is what mesos-clang-format suggests and I find that slightly better readable, no? ``` return master->registrar ->apply(Owned<Operation>(new maintenance::UpdateSchedule(schedule))) .then(defer(master->self(), [this, schedule](bool result) { return ___updateMaintenanceSchedule(schedule, result); })); ``` src/master/http.cpp Lines 4125-4126 (original), 4174-4175 (patched) <https://reviews.apache.org/r/59099/#comment251316> Why touching these? src/master/http.cpp Line 4139 (original), 4188 (patched) <https://reviews.apache.org/r/59099/#comment251317> Why touching these? - Till Toenshoff On June 12, 2017, 1:31 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59099/ > ----------------------------------------------------------- > > (Updated June 12, 2017, 1:31 p.m.) > > > Review request for mesos, Adam B, Greg Mann, and Till Toenshoff. > > > Bugs: MESOS-7415 > https://issues.apache.org/jira/browse/MESOS-7415 > > > Repository: mesos > > > Description > ------- > > Enables the use of authorization for the 'UPDATE_MAINTENANCE_SCHEDULE' > v1 API call, using the ACL 'UpdateMaintenanceSchedule' and the action > of the same name as the API call. > > It also updates the 'ApiTests' to take into account the authorization > case. > > > Diffs > ----- > > src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 > src/master/master.hpp e8ddddf273256b14cde1cac390163f948241757f > src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54 > > > Diff: https://reviews.apache.org/r/59099/diff/8/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
