----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60016/#review177788 -----------------------------------------------------------
src/common/resources.cpp Line 223 (original), 231 (patched) <https://reviews.apache.org/r/60016/#comment251505> At first I wrote "Whoa, don't we still need to check role here?" and then I remembered you said all of the resources are normalized into the new format, but I needed a lot of non-local knowledge here, is that documented somewhere? It seems a little odd to have come into this patch reading validation code that shows two possible formats, but this code is assuming one over the other. We probably need a NOTE here and in other places that assume the new format to refer to a comment that talks about this invariant? Shouldn't I have seen code before this patch that actually enforces that `Resources` contains only the new format? src/common/resources.cpp Line 239 (original), 245 (patched) <https://reviews.apache.org/r/60016/#comment251508> Ditto here, would be nice to refer to a comment about the new format being what all Resources are being normalized to. src/common/resources.cpp Line 312 (original), 320 (patched) <https://reviews.apache.org/r/60016/#comment251506> Ditto here. - Benjamin Mahler On June 13, 2017, 8:35 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60016/ > ----------------------------------------------------------- > > (Updated June 13, 2017, 8:35 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7655 > https://issues.apache.org/jira/browse/MESOS-7655 > > > Repository: mesos > > > Description > ------- > > Resources: Update the comparison functions. > > > Diffs > ----- > > src/common/resources.cpp f89f1aae7845f1e93dd5947de2e7a8e2bfce8bc4 > src/v1/resources.cpp 24240eedc4b2747ca02998534437318c3396db4d > > > Diff: https://reviews.apache.org/r/60016/diff/2/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
