----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60016/#review178237 -----------------------------------------------------------
src/common/resources.cpp Line 239 (original), 245 (patched) <https://reviews.apache.org/r/60016/#comment252112> Do we validate it is a stack? Maybe it suffices to call it a list here? src/common/resources.cpp Lines 244-246 (original), 250-254 (patched) <https://reviews.apache.org/r/60016/#comment252113> Is it guaranteed that reservations are always sorted in the list? src/common/resources.cpp Lines 328-335 (original), 334-343 (patched) <https://reviews.apache.org/r/60016/#comment252114> Ditto. src/common/resources.cpp Lines 415-422 (original), 421-430 (patched) <https://reviews.apache.org/r/60016/#comment252115> Ditto. This chunks appears for the third time in this file. Looks like a candidate for factoring out : ) - Alexander Rukletsov On June 13, 2017, 8:35 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60016/ > ----------------------------------------------------------- > > (Updated June 13, 2017, 8:35 a.m.) > > > Review request for mesos, Benjamin Mahler and Neil Conway. > > > Bugs: MESOS-7655 > https://issues.apache.org/jira/browse/MESOS-7655 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/common/resources.cpp cc305e64cadc9fab913ede987625fc1839646306 > src/v1/resources.cpp 03d6c8098a24a2751617d14f2664de1d88318414 > > > Diff: https://reviews.apache.org/r/60016/diff/5/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
