> On June 13, 2017, 6:42 p.m., Jie Yu wrote: > > src/launcher/default_executor.cpp > > Lines 371 (patched) > > <https://reviews.apache.org/r/59949/diff/1/?file=1746882#file1746882line371> > > > > I'd add a TODO here. Because for bridge mode, `self().address.ip` might > > be the advertise IP (i.e., agent IP), which is not what we've wanted here. > > Avinash sridharan wrote: > From a CNI perspective the BRIDGE mode is just another CNI network, so > the self().address.ip will be the IP on the BRIDGE network which is what is > expected. So for the time being dropping this comment. Please open if you > still feel this is an issue.
i am just giving an example here. Any container that set LIBPROCESS_ADVERTISE_IP env var will change `self().address.ip`. And this is not the IP we want to set for `MESOS_CONTAINER_IP` env var. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59949/#review177778 ----------------------------------------------------------- On June 14, 2017, 1:57 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59949/ > ----------------------------------------------------------- > > (Updated June 14, 2017, 1:57 p.m.) > > > Review request for mesos, Anand Mazumdar and Jie Yu. > > > Bugs: MESOS-7631 > https://issues.apache.org/jira/browse/MESOS-7631 > > > Repository: mesos > > > Description > ------- > > Added `MESOS_CONTAINER_IP` to tasks launched by `DefaultExecutor`. > > > Diffs > ----- > > src/launcher/default_executor.cpp 91a4e1ebed3ff979bd3c0f7f46559cec24f61c2c > > > Diff: https://reviews.apache.org/r/59949/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Avinash sridharan > >
