> On June 13, 2017, 10:58 a.m., Benjamin Mahler wrote: > > src/common/resources.cpp > > Lines 844-845 (original), 864-868 (patched) > > <https://reviews.apache.org/r/60013/diff/1/?file=1748842#file1748842line864> > > > > Do you want to add a function to roles.hpp for checking this? > > > > ``` > > bool isSubRole(const string& parentRole, const string& subRole); > > ```
https://reviews.apache.org/r/60063 - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60013/#review177695 ----------------------------------------------------------- On June 13, 2017, 1:34 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60013/ > ----------------------------------------------------------- > > (Updated June 13, 2017, 1:34 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7655 > https://issues.apache.org/jira/browse/MESOS-7655 > > > Repository: mesos > > > Description > ------- > > Resources: Updated the validation logic. > > > Diffs > ----- > > src/common/resources.cpp 7b3fae1a34150964ba3831a3aef2f868e338aef8 > src/master/validation.hpp 6b53e34f67f6a8b338b92db6cb7398f1dccce5a9 > src/master/validation.cpp f45f9e816bdaf6304794604570edbd68d5faf715 > src/tests/master_validation_tests.cpp > 4e7ce74edf0069b9317f869b299694a45e2a62f2 > src/v1/resources.cpp 236fe17730918479a33314e51d14f3cc1679d432 > > > Diff: https://reviews.apache.org/r/60013/diff/5/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
