----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60013/#review178145 -----------------------------------------------------------
Fix it, then Ship it! src/common/resources.cpp Lines 511-512 (original), 511-512 (patched) <https://reviews.apache.org/r/60013/#comment251991> Can you commit this unrelated formatting change separately? Would be good to minimize the diff for posterity src/common/resources.cpp Lines 522-523 (original), 522-523 (patched) <https://reviews.apache.org/r/60013/#comment251992> Ditto here src/master/validation.cpp Lines 1854-1856 (original), 1902-1904 (patched) <https://reviews.apache.org/r/60013/#comment251994> Commit this separately to minimize the diff? src/master/validation.cpp Lines 2027-2030 (original), 2091-2094 (patched) <https://reviews.apache.org/r/60013/#comment251995> Commit this separately to minimize the diff? src/tests/master_validation_tests.cpp Lines 1987-1989 (original), 1987 (patched) <https://reviews.apache.org/r/60013/#comment251996> This seems strictly less readable to me, the intention of capturing the 'error' was to have a clear expectation: ``` EXPECT_NONE(error); ``` Ditto on the others below. It's also unrelated to this change :) src/v1/resources.cpp Lines 513-525 (original), 513-525 (patched) <https://reviews.apache.org/r/60013/#comment251997> Ditto v0 comments. Could you commit this separately in the interest of getting this diff down to its essential? - Benjamin Mahler On June 15, 2017, 7:39 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60013/ > ----------------------------------------------------------- > > (Updated June 15, 2017, 7:39 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7655 > https://issues.apache.org/jira/browse/MESOS-7655 > > > Repository: mesos > > > Description > ------- > > This patch updates `Resources::validate`, and `resource::validate`. > > The `Resources::validate` function ensures that the resources are > either in the 'pre-' or 'post-' reservation-refinement formats, > but not both. > > The `resource::validate` function takes an optional framework > capabilities and ensures that the resources format matches > the framework's RESERVATION_REFINEMENT capbility. > > > Diffs > ----- > > src/common/resources.cpp e37519ea83c564b72c842c662fe784731c6e44b0 > src/master/validation.hpp 1be9f082024a5295e6a20bb047c15217c1866ca3 > src/master/validation.cpp 1d10e6bb0dfada7d6aa7085aa99c5bfa8099643e > src/tests/master_validation_tests.cpp > 83370fa5653fe5da666ec577b05001c4a5499848 > src/v1/resources.cpp 40ef32f11be3f2710a0e634f3225314fb9ae5aec > > > Diff: https://reviews.apache.org/r/60013/diff/13/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
