----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60015/#review178022 -----------------------------------------------------------
src/v1/resources.cpp Line 975 (original), 971 (patched) <https://reviews.apache.org/r/60015/#comment251777> This still uses `resource.role()` in `v1` -- which seems wrong? src/v1/resources.cpp Line 1782 (original), 1794 (patched) <https://reviews.apache.org/r/60015/#comment251776> Seems like the `v1` copy of this function is not updated in the same way as the unversioned copy. - Neil Conway On June 13, 2017, 8:34 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60015/ > ----------------------------------------------------------- > > (Updated June 13, 2017, 8:34 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7655 > https://issues.apache.org/jira/browse/MESOS-7655 > > > Repository: mesos > > > Description > ------- > > Resources: Introduced `reservationRole` and `reservationPrincipal`. > > > Diffs > ----- > > include/mesos/resources.hpp 2b55847be79c7930b598ef31c932e8aca0fa73db > include/mesos/v1/resources.hpp 7c6e8569b990ad34fd6c449b31140f844dae222f > src/common/resources.cpp 7b3fae1a34150964ba3831a3aef2f868e338aef8 > src/master/validation.cpp f45f9e816bdaf6304794604570edbd68d5faf715 > src/v1/resources.cpp 236fe17730918479a33314e51d14f3cc1679d432 > > > Diff: https://reviews.apache.org/r/60015/diff/8/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
