----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60562/#review179395 -----------------------------------------------------------
src/master/master.cpp Lines 3929 (patched) <https://reviews.apache.org/r/60562/#comment254069> Just for clarification, is the plan for this block to ultimately absorb the mutating part of `validateAndUpgrade`? Looking at your patch https://reviews.apache.org/r/60563/ makes this look pretty (validation and update order inverted there wrt. here). src/master/master.cpp Lines 3932-3936 (patched) <https://reviews.apache.org/r/60562/#comment254067> Nice to see these finally handled by a `switch` instead of a couple of `if` statements! - Benjamin Bannier On June 30, 2017, 11:01 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60562/ > ----------------------------------------------------------- > > (Updated June 30, 2017, 11:01 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7735 > https://issues.apache.org/jira/browse/MESOS-7735 > > > Repository: mesos > > > Description > ------- > > It used to be that the minor adjustments that were made to operations > were done in various places across `accept` and `_accept`. > > The "executor-injection" for LAUNCH_GROUP was at the beginning of > `accept`, "allocation-info-injection" for MULTI_ROLE was after offer > validation, and "health-check-injection" for LAUNCH was in `_accept`. > > The `Master::accept` function is now broken down into distinct > "metrics accounting", "offer validation", "operation-adjustments", and > "authorization" stages. > > > Diffs > ----- > > src/master/master.cpp 276b18e4d1bab7e9b28c1c93fe13c93a38abc5cd > > > Diff: https://reviews.apache.org/r/60562/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >
