> On July 1, 2017, 2:13 a.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 3997 (patched) > > <https://reviews.apache.org/r/60562/diff/1/?file=1767517#file1767517line4011> > > > > Can you log a warning here?
I wouldn't log a warning here since it's the responsibility of the processing of operations that occurs later to log accordingly when dealing with unknown operations. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60562/#review179450 ----------------------------------------------------------- On June 30, 2017, 9:01 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60562/ > ----------------------------------------------------------- > > (Updated June 30, 2017, 9:01 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7735 > https://issues.apache.org/jira/browse/MESOS-7735 > > > Repository: mesos > > > Description > ------- > > It used to be that the minor adjustments that were made to operations > were done in various places across `accept` and `_accept`. > > The "executor-injection" for LAUNCH_GROUP was at the beginning of > `accept`, "allocation-info-injection" for MULTI_ROLE was after offer > validation, and "health-check-injection" for LAUNCH was in `_accept`. > > The `Master::accept` function is now broken down into distinct > "metrics accounting", "offer validation", "operation-adjustments", and > "authorization" stages. > > > Diffs > ----- > > src/master/master.cpp 276b18e4d1bab7e9b28c1c93fe13c93a38abc5cd > > > Diff: https://reviews.apache.org/r/60562/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >
