----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60563/#review179397 -----------------------------------------------------------
src/common/resources_utils.cpp Line 199 (original), 199 (patched) <https://reviews.apache.org/r/60563/#comment254076> It seems by unconditionally calling `mutable_xyz` for `repeated` fields `xyz` below we might add default entries to them if they were empty before. AFAICTt this might not be what callers of this function expect. src/common/resources_utils.cpp Line 201 (original), 201 (patched) <https://reviews.apache.org/r/60563/#comment254070> Should we `CHECK_NOTNULL` somewhere here? - Benjamin Bannier On June 30, 2017, 11:01 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60563/ > ----------------------------------------------------------- > > (Updated June 30, 2017, 11:01 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7735 > https://issues.apache.org/jira/browse/MESOS-7735 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/common/resources_utils.hpp 7128297c45fbf94af9384b678bf201f3d9c48b65 > src/common/resources_utils.cpp 3a6a57817d4b0c4f4133b0a8d2b6f4d9ea31ea6b > > > Diff: https://reviews.apache.org/r/60563/diff/1/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
