> On July 1, 2017, 2:25 a.m., Vinod Kone wrote: > > src/common/resources_utils.cpp > > Line 199 (original), 199 (patched) > > <https://reviews.apache.org/r/60563/diff/2/?file=1767989#file1767989line199> > > > > I feel like validate and upgrade could be split into 2 independent > > helpers, but if there is no use case yet, that's fine.
Would be good to have a comment about why they're merged, wasn't obvious to me either. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60563/#review179451 ----------------------------------------------------------- On July 1, 2017, 12:56 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60563/ > ----------------------------------------------------------- > > (Updated July 1, 2017, 12:56 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7735 > https://issues.apache.org/jira/browse/MESOS-7735 > > > Repository: mesos > > > Description > ------- > > Updated `validateAndUpgradeResources` to operate on `Operation`s. > > > Diffs > ----- > > src/common/resources_utils.hpp 7128297c45fbf94af9384b678bf201f3d9c48b65 > src/common/resources_utils.cpp 3a6a57817d4b0c4f4133b0a8d2b6f4d9ea31ea6b > > > Diff: https://reviews.apache.org/r/60563/diff/2/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
