> On June 30, 2017, 10:24 p.m., Gastón Kleiman wrote: > > docs/modules.md > > Line 91 (original), 91 (patched) > > <https://reviews.apache.org/r/60520/diff/1/?file=1766623#file1766623line91> > > > > Is the trailing comma here valid?
Oops, looke like I picked up an unrelated change. I'll rebase this away. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60520/#review179418 ----------------------------------------------------------- On June 28, 2017, 10:49 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60520/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 10:49 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Jiang Yan > Xu. > > > Repository: mesos > > > Description > ------- > > Fix a number of places where we were depending on symbols made > visible by <process/posix/subprocess.hpp>. In most cases, this is > just tweaking the includes, but in the Checker we just duplicate > the trivial fork(2) helper since that is easer than trying to > export it as a libprocess API. > > > Diffs > ----- > > docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3 > src/checks/checker_process.cpp 66f5452bb5f9c7f45819c221be7b098e5999b7a7 > src/slave/containerizer/mesos/isolators/volume/image.cpp > c89af3e0a16f769c45f2846d1e76baedb8248d4d > src/uri/fetchers/docker.cpp 7f3e4e73d1dc5d15f875e2890acbe5369fb59d78 > > > Diff: https://reviews.apache.org/r/60520/diff/1/ > > > Testing > ------- > > make check (Fedora 26). > > > Thanks, > > James Peach > >
