> On July 6, 2017, 6:40 a.m., Kevin Klues wrote: > > Are we sure that we will be able to properly build the CLI into a binary > > with this change? > > Kevin Klues wrote: > Or more accurately, are we sure we will be able to properly build the CLI > into a binary once we start imporint libraries from this new location (I'm > mostly worried about the relative path in the new pythonpath).
yes, our internal CLI which this changed is based on has the same setup and uses pyinstaller to build the binary. it's already in production and works well :) - Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review179757 ----------------------------------------------------------- On July 6, 2017, 5:14 p.m., Eric Chung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58394/ > ----------------------------------------------------------- > > (Updated July 6, 2017, 5:14 p.m.) > > > Review request for mesos, Armand Grillet, Jason Lai, Joseph Wu, and Kevin > Klues. > > > Bugs: MESOS-7310 > https://issues.apache.org/jira/browse/MESOS-7310 > > > Repository: mesos > > > Description > ------- > > Review: https://reviews.apache.org/r/58394 > > > Diffs > ----- > > src/cli_new/bootstrap 6d62e9adf1d543ed00a3a2cf2484edf1c33ee443 > src/python/.gitignore PRE-CREATION > src/python/lib/mesos/__init__.py PRE-CREATION > > > Diff: https://reviews.apache.org/r/58394/diff/5/ > > > Testing > ------- > > Under src/cli_new: > 1\. ./bootstrap > 2\. . ./activate > 3\. python > 4\. >>> import mesos > 5\. >>> mesos.\_\_path\_\_ > 6\. verify that the path printed out is indeed at src/python/lib/mesos > > > Thanks, > > Eric Chung > >
