> On July 6, 2017, 6:50 a.m., Kevin Klues wrote: > > src/cli_new/bootstrap > > Line 11 (original), 11 (patched) > > <https://reviews.apache.org/r/58394/diff/4/?file=1767155#file1767155line11> > > > > Maybe add another variable here called: > > ``` > > MESOS_PYTHONDIR="$( cd ${CURRDIR}/../python && pwd -P)" > > ``` > > > > Then you can change the line below from: > > ``` > > echo "${CURRDIR}/../python/lib" >> > > ${SITE_PACKAGES}/_virtualenv_path_extensions.pth > > ``` > > to > > ``` > > echo "${MESOS_PYTHONDIR}/lib" >> > > ${SITE_PACKAGES}/_virtualenv_path_extensions.pth > > ``` > > > > I'm just worried that using a relative path here will mess up building > > into a binary CLI down the road.
good call! - Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58394/#review179759 ----------------------------------------------------------- On July 6, 2017, 5:14 p.m., Eric Chung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58394/ > ----------------------------------------------------------- > > (Updated July 6, 2017, 5:14 p.m.) > > > Review request for mesos, Armand Grillet, Jason Lai, Joseph Wu, and Kevin > Klues. > > > Bugs: MESOS-7310 > https://issues.apache.org/jira/browse/MESOS-7310 > > > Repository: mesos > > > Description > ------- > > Review: https://reviews.apache.org/r/58394 > > > Diffs > ----- > > src/cli_new/bootstrap 6d62e9adf1d543ed00a3a2cf2484edf1c33ee443 > src/python/.gitignore PRE-CREATION > src/python/lib/mesos/__init__.py PRE-CREATION > > > Diff: https://reviews.apache.org/r/58394/diff/5/ > > > Testing > ------- > > Under src/cli_new: > 1\. ./bootstrap > 2\. . ./activate > 3\. python > 4\. >>> import mesos > 5\. >>> mesos.\_\_path\_\_ > 6\. verify that the path printed out is indeed at src/python/lib/mesos > > > Thanks, > > Eric Chung > >
