> On July 4, 2017, 1:22 a.m., Avinash sridharan wrote: > > docs/configuration.md > > Lines 1312 (patched) > > <https://reviews.apache.org/r/60500/diff/1/?file=1766230#file1766230line1312> > > > > `ContainerInfo.docker.parameter` > > Qian Zhang wrote: > The field name is `parameters` rather than `parameter`. > > Avinash sridharan wrote: > Qian I meant put the field in quotest `ContainerInfo.docker.parameters`.
Avinash, did you mean `ContainerInfo.docker.parameters`? That will make the line in flags.cpp exceeding 80 chars, and when you look at the flag `default_container_info`, in its help message, the `ContainerInfo` is not in quotest too. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review179520 ----------------------------------------------------------- On July 5, 2017, 3:03 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60500/ > ----------------------------------------------------------- > > (Updated July 5, 2017, 3:03 p.m.) > > > Review request for mesos, Avinash sridharan and Jie Yu. > > > Bugs: MESOS-7709 > https://issues.apache.org/jira/browse/MESOS-7709 > > > Repository: mesos > > > Description > ------- > > Introduced `--default_container_dns` agent flag. > > > Diffs > ----- > > docs/configuration.md 007d0f556375f331148c9ad09be8b301ab31a01c > src/messages/flags.hpp 70ad58c33067a0b058deafdcc4ffc5f554b6ca72 > src/messages/flags.proto e87075f19714739b93d9f4aa33ea8686a1bb5613 > src/slave/flags.hpp c6803eb54e09a5497755e1e5fef2872193eacba6 > src/slave/flags.cpp 398768656b5fa3b7c85474de2b4b008bf7b85cb3 > > > Diff: https://reviews.apache.org/r/60500/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
