----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60764/#review180388 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp Lines 151 (patched) <https://reviews.apache.org/r/60764/#comment255534> No need `std::` src/slave/containerizer/mesos/containerizer.cpp Line 155 (original), 170 (patched) <https://reviews.apache.org/r/60764/#comment255535> Kill this empty line. src/slave/containerizer/mesos/containerizer.cpp Line 181 (original), 203 (patched) <https://reviews.apache.org/r/60764/#comment255541> Not yours. A period in the end. src/slave/containerizer/mesos/containerizer.cpp Lines 182-192 (original), 204-221 (patched) <https://reviews.apache.org/r/60764/#comment255545> Can we merge the logic of these two `if` blocks? I mean: 1. Get the count by calling `std::count_if()`. 2. If the count > 1, error out. 3. Else if the count == 0, do the insert. In this way, we do not need to call `strings::contains()` anymore. src/slave/containerizer/mesos/containerizer.cpp Lines 238 (patched) <https://reviews.apache.org/r/60764/#comment255543> Ditto src/slave/containerizer/mesos/containerizer.cpp Lines 207-210 (original), 238-250 (patched) <https://reviews.apache.org/r/60764/#comment255546> Ditto. - Qian Zhang On July 11, 2017, 7:13 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60764/ > ----------------------------------------------------------- > > (Updated July 11, 2017, 7:13 p.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Refactor the isolator dependency checks to immediately tokenize the > isolator string, which makes it easier to check various consistency > conditions. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 9376d14d66f5dc7e91c7c0e9da253f5eb9347539 > > > Diff: https://reviews.apache.org/r/60764/diff/1/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
