----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/#review180730 -----------------------------------------------------------
src/slave/gc.hpp Lines 114-117 (original), 115-118 (patched) <https://reviews.apache.org/r/53479/#comment255948> I see that `promise == that.promise` here is required by the Multimap but does it make sense to have `PathInfo` equality depend only on the path? I don't think `Promise` is supposed to be comparable. src/slave/gc.cpp Line 100 (original), 119 (patched) <https://reviews.apache.org/r/53479/#comment255950> `s/(unsigned long)1/1u/` src/slave/gc.cpp Lines 209 (patched) <https://reviews.apache.org/r/53479/#comment255951> `s/(unsigned long)1/1u/` - Jiang Yan Xu On July 14, 2017, 6:23 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53479/ > ----------------------------------------------------------- > > (Updated July 14, 2017, 6:23 p.m.) > > > Review request for mesos, Benjamin Mahler and Jiang Yan Xu. > > > Bugs: MESOS-6549 > https://issues.apache.org/jira/browse/MESOS-6549 > > > Repository: mesos > > > Description > ------- > > - Previously, rmdir operations were serialized > through the garbage collector. Expensive removal > events had the potential to delay task launch. > - MESOS-6549 > > > Added: https://reviews.apache.org/r/60893/ > > > Diffs > ----- > > src/slave/gc.hpp 5ea82456cffa374203371f227b6f0ee00296553e > src/slave/gc.cpp 961f547793984449ea113d9664b12b5033638c58 > > > Diff: https://reviews.apache.org/r/53479/diff/8/ > > > Testing > ------- > > `./bin/mesos-tests.sh --gtest_filter="GarbageCollector*" --gtest_repeat=100 > --gtest_break_on_failure` > > > Thanks, > > Jacob Janco > >
