----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53479/#review180877 -----------------------------------------------------------
Ship it! Committing with these additional edits. src/slave/gc.cpp Lines 20 (patched) <https://reviews.apache.org/r/53479/#comment256192> We don't need this anymore. src/slave/gc.cpp Lines 25 (patched) <https://reviews.apache.org/r/53479/#comment256194> This should be below foreach.hpp. src/slave/gc.cpp Lines 202 (patched) <https://reviews.apache.org/r/53479/#comment256196> Included `#include <process/check.hpp>` for this. src/slave/gc.cpp Lines 204 (patched) <https://reviews.apache.org/r/53479/#comment256191> Removed this logging as it doesn't provide much additional info on top of existing logging, other than the fact that some callback has been called. - Jiang Yan Xu On July 18, 2017, 3:15 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53479/ > ----------------------------------------------------------- > > (Updated July 18, 2017, 3:15 p.m.) > > > Review request for mesos, Benjamin Mahler and Jiang Yan Xu. > > > Bugs: MESOS-6549 > https://issues.apache.org/jira/browse/MESOS-6549 > > > Repository: mesos > > > Description > ------- > > - Previously, rmdir operations were serialized > through the garbage collector. Expensive removal > events had the potential to delay task launch. > - MESOS-6549 > > > Diffs > ----- > > src/slave/gc.hpp 5ea82456cffa374203371f227b6f0ee00296553e > src/slave/gc.cpp 961f547793984449ea113d9664b12b5033638c58 > > > Diff: https://reviews.apache.org/r/53479/diff/10/ > > > Testing > ------- > > `./bin/mesos-tests.sh --gtest_filter="GarbageCollector*" --gtest_repeat=100 > --gtest_break_on_failure` > > > Thanks, > > Jacob Janco > >
