-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60932/#review180794
-----------------------------------------------------------




include/mesos/mesos.proto
Lines 2886 (patched)
<https://reviews.apache.org/r/60932/#comment256046>

    Just curious, the reason that this is a `repeated` field is there are 5 
operations (total/read/write/sync/async)?



include/mesos/mesos.proto
Lines 2950 (patched)
<https://reviews.apache.org/r/60932/#comment256043>

    Why do we need this msg? I do not see it is used anywhere.



include/mesos/mesos.proto
Lines 2955 (patched)
<https://reviews.apache.org/r/60932/#comment256044>

    If we introduce a field like this, does that mean we will fill it in 
`BlkioSubsystem::status()` since `CgroupInfo` is part of `ContainerStatus`?


- Qian Zhang


On July 18, 2017, 8:44 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60932/
> -----------------------------------------------------------
> 
> (Updated July 18, 2017, 8:44 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, 
> Vinod Kone, and Zhitao Li.
> 
> 
> Bugs: MESOS-6162
>     https://issues.apache.org/jira/browse/MESOS-6162
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added protobuf scheme for blkio subsystem in CgroupInfo.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto ab2a372184b7cfbaf7a38e90f487cba38c3e80b8 
> 
> 
> Diff: https://reviews.apache.org/r/60932/diff/1/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to