> On July 18, 2017, 6:31 a.m., Qian Zhang wrote:
> > include/mesos/mesos.proto
> > Lines 2950 (patched)
> > <https://reviews.apache.org/r/60932/diff/1/?file=1778071#file1778071line2950>
> >
> > Why do we need this msg? I do not see it is used anywhere.
This was left by Jason. Should be removed in favor of:
```
message Statistics {
repeated CFQ.Statistics cfq = 1;
repeated CFQ.Statistics cfq_recursive = 2;
repeated Throttling.Statistics throttling = 3;
}
```
Thanks, Qian!
> On July 18, 2017, 6:31 a.m., Qian Zhang wrote:
> > include/mesos/mesos.proto
> > Lines 2955 (patched)
> > <https://reviews.apache.org/r/60932/diff/1/?file=1778071#file1778071line2955>
> >
> > If we introduce a field like this, does that mean we will fill it in
> > `BlkioSubsystem::status()` since `CgroupInfo` is part of `ContainerStatus`?
I would suggest let's remove this field and leave a TODO here, which will be
addressed when we introduce the `prepare` and `status` functions. What do you
think?
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60932/#review180794
-----------------------------------------------------------
On July 17, 2017, 5:44 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60932/
> -----------------------------------------------------------
>
> (Updated July 17, 2017, 5:44 p.m.)
>
>
> Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang,
> Vinod Kone, and Zhitao Li.
>
>
> Bugs: MESOS-6162
> https://issues.apache.org/jira/browse/MESOS-6162
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added protobuf scheme for blkio subsystem in CgroupInfo.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto ab2a372184b7cfbaf7a38e90f487cba38c3e80b8
>
>
> Diff: https://reviews.apache.org/r/60932/diff/1/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Gilbert Song
>
>
