----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60933/#review181093 -----------------------------------------------------------
Fix it, then Ship it! src/linux/cgroups.hpp Lines 451 (patched) <https://reviews.apache.org/r/60933/#comment256519> Just curious, this refers to the blkio file `blkio.weight` and `blkio.leaf_weight`, right? src/linux/cgroups.cpp Lines 1969 (patched) <https://reviews.apache.org/r/60933/#comment256525> We do not need to explicitly set it to `None()`, just `Option<Device>` should be OK. - Qian Zhang On July 21, 2017, 7:58 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60933/ > ----------------------------------------------------------- > > (Updated July 21, 2017, 7:58 a.m.) > > > Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and > Zhitao Li. > > > Bugs: MESOS-6162 > https://issues.apache.org/jira/browse/MESOS-6162 > > > Repository: mesos > > > Description > ------- > > - Data structure for Blkio entities > - Stats helpers for blkio.throttle.io* (generic blkio stats) > - Stats helpers for blkio.io* (CFQ related stats) > - Comments from the kernel blkio doc for helper functions > > > Diffs > ----- > > src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433 > src/linux/cgroups.cpp 334005abfc4ec9b20b7dc0212d852ba1f505dbb5 > > > Diff: https://reviews.apache.org/r/60933/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
