> On July 20, 2017, 11:43 p.m., Qian Zhang wrote: > > src/linux/cgroups.hpp > > Lines 451 (patched) > > <https://reviews.apache.org/r/60933/diff/3/?file=1780531#file1780531line451> > > > > Just curious, this refers to the blkio file `blkio.weight` and > > `blkio.leaf_weight`, right?
Yes. > On July 20, 2017, 11:43 p.m., Qian Zhang wrote: > > src/linux/cgroups.cpp > > Lines 1969 (patched) > > <https://reviews.apache.org/r/60933/diff/3/?file=1780532#file1780532line1969> > > > > We do not need to explicitly set it to `None()`, just `Option<Device>` > > should be OK. I personally very like it to be explicit since it would remind people the fact that the device may not exist. But I decide to remove it for duplicate variable assignment. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60933/#review181093 ----------------------------------------------------------- On July 20, 2017, 4:58 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60933/ > ----------------------------------------------------------- > > (Updated July 20, 2017, 4:58 p.m.) > > > Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and > Zhitao Li. > > > Bugs: MESOS-6162 > https://issues.apache.org/jira/browse/MESOS-6162 > > > Repository: mesos > > > Description > ------- > > - Data structure for Blkio entities > - Stats helpers for blkio.throttle.io* (generic blkio stats) > - Stats helpers for blkio.io* (CFQ related stats) > - Comments from the kernel blkio doc for helper functions > > > Diffs > ----- > > src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433 > src/linux/cgroups.cpp 334005abfc4ec9b20b7dc0212d852ba1f505dbb5 > > > Diff: https://reviews.apache.org/r/60933/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
