----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59960/#review181157 -----------------------------------------------------------
src/linux/cgroups.hpp Lines 419 (patched) <https://reviews.apache.org/r/59960/#comment256616> `major` and `minor` are [macros](https://www.freebsd.org/cgi/man.cgi?query=major()) on many platforms, so you can't safely use these function names or the scope operator here. src/linux/cgroups.hpp Lines 442 (patched) <https://reviews.apache.org/r/59960/#comment256618> Can we come up with a better name than `Entry`? I think that this is a per-device sample, so `DeviceValue`? Similar for `StatEntry`. src/linux/cgroups.cpp Lines 1954 (patched) <https://reviews.apache.org/r/59960/#comment256617> `makedev` might also be a macro. - James Peach On June 9, 2017, 11:24 p.m., Jason Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59960/ > ----------------------------------------------------------- > > (Updated June 9, 2017, 11:24 p.m.) > > > Review request for mesos, Eric Chung, Xiaojian Huang, Gilbert Song, haosdent > huang, Jie Yu, and Zhitao Li. > > > Bugs: MESOS-6162 > https://issues.apache.org/jira/browse/MESOS-6162 > > > Repository: mesos > > > Description > ------- > > * Data structure for Blkio entities > * Stats helpers for `blkio.throttle.io*` (generic blkio stats) > * Stats helpers for `blkio.io*` (CFQ related stats) > * Comments from the kernel blkio doc for helper functions > > > Diffs > ----- > > src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433 > src/linux/cgroups.cpp 334005abfc4ec9b20b7dc0212d852ba1f505dbb5 > > > Diff: https://reviews.apache.org/r/59960/diff/1/ > > > Testing > ------- > > > Thanks, > > Jason Lai > >
