----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61098/ -----------------------------------------------------------
(Updated July 25, 2017, 9:14 p.m.) Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu. Changes ------- Refactored and moved CMake-related updates into a separated patch: https://reviews.apache.org/r/61118/ Summary (updated) ----------------- Added unit tests for gRPC support in libprocess. Bugs: MESOS-7810 https://issues.apache.org/jira/browse/MESOS-7810 Repository: mesos Description (updated) ------- We tested the following 6 scenarios when making gRPC calls: 1. The server responds with an OK. 2. The server responds with a failure. 3. The client discards the calls. 4. The client makes mulitple outstanding calls. 5. The client shuts down during a call. 6. The server is unreachable. 7. The server dose not respond in time. `grpc_tests.pb.h`, `grpc_tests.pb.cc`, `grpc_tests.grpc.pb.h` and `grpc_tests.grpc.pb.cc` are created with protobuf 3.3.0 and grpc 1.4.2 through the following command, assuming the current working directory is `3rdparty/libprocess/src/tests`: $ /path/to/protoc -I. --cpp_out=. --grpc_out=. \ --plugin=protoc-gen-grpc=/path/to/grpc_cpp_plugin \ grpc_tests.proto Diffs (updated) ----- 3rdparty/libprocess/src/tests/grpc_tests.cpp PRE-CREATION 3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.h PRE-CREATION 3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.cc PRE-CREATION 3rdparty/libprocess/src/tests/grpc_tests.pb.h PRE-CREATION 3rdparty/libprocess/src/tests/grpc_tests.pb.cc PRE-CREATION 3rdparty/libprocess/src/tests/grpc_tests.proto PRE-CREATION Diff: https://reviews.apache.org/r/61098/diff/2/ Changes: https://reviews.apache.org/r/61098/diff/1-2/ Testing (updated) ------- N/A Thanks, Chun-Hung Hsiao
