> On July 28, 2017, 7:57 p.m., Jie Yu wrote: > > 3rdparty/libprocess/src/tests/grpc_tests.cpp > > Lines 282 (patched) > > <https://reviews.apache.org/r/61098/diff/4/?file=1784965#file1784965line282> > > > > curious what happened if you don't call `shutdown->set(Nothing())` > > above?
Then the `AWAIT_READY` in the mock server will time out and thus the test will fail. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61098/#review181712 ----------------------------------------------------------- On July 28, 2017, 12:49 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61098/ > ----------------------------------------------------------- > > (Updated July 28, 2017, 12:49 a.m.) > > > Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-7810 > https://issues.apache.org/jira/browse/MESOS-7810 > > > Repository: mesos > > > Description > ------- > > We tested the following 6 scenarios when making gRPC calls: > > 1. The server responds with an OK. > 2. The server responds with a failure. > 3. The client discards the calls. > 4. The client makes mulitple outstanding calls. > 5. The client shuts down during a call. > 6. The server is unreachable. > 7. The server dose not respond in time. > > `grpc_tests.pb.h`, `grpc_tests.pb.cc`, `grpc_tests.grpc.pb.h` and > `grpc_tests.grpc.pb.cc` are created with protobuf 3.3.0 and grpc > 1.4.2 through the following command, assuming the current working > directory is `3rdparty/libprocess/src/tests`: > $ /path/to/protoc -I. --cpp_out=. --grpc_out=. \ > --plugin=protoc-gen-grpc=/path/to/grpc_cpp_plugin \ > grpc_tests.proto > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/grpc_tests.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.h PRE-CREATION > 3rdparty/libprocess/src/tests/grpc_tests.grpc.pb.cc PRE-CREATION > 3rdparty/libprocess/src/tests/grpc_tests.pb.h PRE-CREATION > 3rdparty/libprocess/src/tests/grpc_tests.pb.cc PRE-CREATION > 3rdparty/libprocess/src/tests/grpc_tests.proto PRE-CREATION > > > Diff: https://reviews.apache.org/r/61098/diff/4/ > > > Testing > ------- > > N/A > > > Thanks, > > Chun-Hung Hsiao > >
